From 2863d2c6e5733d2ccb5ee0910d26d04bd9230583 Mon Sep 17 00:00:00 2001 From: Guillem Jover Date: Sun, 12 Apr 2020 03:58:12 +0200 Subject: [PATCH] [PATCH libaio 04/26] build: Fix DESTDIR and pathname variables handling The convention for DESTDIR is that it is only prefixed during the install target. In this case we postpone that to the inner Makefile so that it can be invoked directly while preserving the expected semantics. We should also prefer the user specified pathname variables if already set in any way, and do not need to pass them explicitly to the sub-make. Signed-off-by: Guillem Jover Gbp-Pq: Name 0004-build-Fix-DESTDIR-and-pathname-variables-handling.patch --- Makefile | 6 +----- src/Makefile | 16 ++++++++-------- 2 files changed, 9 insertions(+), 13 deletions(-) diff --git a/Makefile b/Makefile index c1fb831..c194d9e 100644 --- a/Makefile +++ b/Makefile @@ -4,17 +4,13 @@ VERSION=$(shell awk '/Version:/ { print $$2 }' $(SPECFILE)) TAG = $(NAME)-$(VERSION) RPMBUILD=$(shell `which rpmbuild >&/dev/null` && echo "rpmbuild" || echo "rpm") -prefix=/usr -includedir=$(prefix)/include -libdir=$(prefix)/lib - default: all all: @$(MAKE) -C src install: - @$(MAKE) -C src install prefix=$(DESTDIR)$(prefix) includedir=$(DESTDIR)$(includedir) libdir=$(DESTDIR)$(libdir) + @$(MAKE) -C src install check: @$(MAKE) -C harness check diff --git a/src/Makefile b/src/Makefile index d080a1b..9a36d0d 100644 --- a/src/Makefile +++ b/src/Makefile @@ -1,6 +1,6 @@ -prefix=/usr -includedir=$(prefix)/include -libdir=$(prefix)/lib +prefix ?= /usr +includedir ?= $(prefix)/include +libdir ?= $(prefix)/lib CFLAGS ?= -g -fomit-frame-pointer -O2 CFLAGS += -Wall -I. -fPIC @@ -59,12 +59,12 @@ $(libname): $(libaio_sobjs) libaio.map $(CC) $(SO_CFLAGS) -Wl,--version-script=libaio.map -Wl,-soname=$(soname) -o $@ $(libaio_sobjs) $(LINK_FLAGS) install: $(all_targets) - install -D -m 644 libaio.h $(includedir)/libaio.h - install -D -m 644 libaio.a $(libdir)/libaio.a + install -D -m 644 libaio.h $(DESTDIR)$(includedir)/libaio.h + install -D -m 644 libaio.a $(DESTDIR)$(libdir)/libaio.a ifeq ($(ENABLE_SHARED),1) - install -D -m 755 $(libname) $(libdir)/$(libname) - ln -sf $(libname) $(libdir)/$(soname) - ln -sf $(libname) $(libdir)/libaio.so + install -D -m 755 $(libname) $(DESTDIR)$(libdir)/$(libname) + ln -sf $(libname) $(DESTDIR)$(libdir)/$(soname) + ln -sf $(libname) $(DESTDIR)$(libdir)/libaio.so endif $(libaio_objs): libaio.h -- 2.39.5